Bluetooth: CAP: Implement unicast to broadcast handover #85642
+2,485
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
cap_handover
branch
from
2455612 to
7d7b6b0
Compare
Thalley
force-pushed
the
cap_handover
branch
3 times, most recently
from
4ef45c7 to
ae9d7b8
Compare
Thalley
force-pushed
the
cap_handover
branch
2 times, most recently
from
b233435 to
3157de2
Compare
Thalley
force-pushed
the
cap_handover
branch
12 times, most recently
from
dbe3d65 to
b9a020b
Compare
Thalley
force-pushed
the
cap_handover
branch
3 times, most recently
from
096bb4b to
d3b48eb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the handover procedures defined in the Bluetooth CAP specification while also refactoring and unifying unicast group APIs (renaming many bap_ functions to cap_ functions) across tests, host, and sample applications.
- Replaces manual extended/periodic advertising start calls with a common helper (start_broadcast_adv) in tests.
- Introduces new CAP unicast group API functions (create, reconfig, add_streams, delete, foreach_stream) with handover support.
- Updates samples, shell commands, and related configuration to support the new handover procedures.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bsim/bluetooth/audio/src/bap_broadcast_source_test.c | Replaces explicit advertising start calls with start_broadcast_adv, consolidating error handling. |
| tests/bsim/bluetooth/audio/src/bap_bass_broadcaster_test.c | Similar consolidation of advertising start logic via start_broadcast_adv. |
| tests/bluetooth/audio/mocks/src/kernel.c | Adds additional fake definitions to support semaphore operations in tests. |
| tests/bluetooth/audio/cap_initiator/uut/bap_unicast_client.c | Implements CAP unicast group API functions with a static unicast group instance. |
| tests/bluetooth/audio/cap_initiator/src/test_unicast_group.c | Adds comprehensive tests for the new CAP unicast group APIs with detailed error cases. |
| subsys/bluetooth/host/shell/bt.c & adv.c | Updates shell commands and adv info reporting to include new extended/periodic advertising states. |
| subsys/bluetooth/audio/shell/cap_initiator.c | Refactors unicast client shell command API calls to use CAP-specific functions. |
| subsys/bluetooth/audio/cap_internal.h, cap_common.c, cap_commander.c | Introduces handover-specific procedure states and helper functions for managing CAP procedures. |
| subsys/bluetooth/audio/bap_unicast_client.c | Updates unicast group validation and adds a foreach_stream iterator with logging. |
| Kconfig.cap | Adds configuration support for CAP handover. |
| Samples & Include files (cap_initiator.c, cap_initiator_unicast.c, bluetooth.h, cap.h, bap.h, release notes) | Updates API usage and documentation to reflect CAP handover and API renaming. |
Thalley
force-pushed
the
cap_handover
branch
2 times, most recently
from
13c8c0f to
b51c9c8
Compare
Thalley
force-pushed
the
cap_handover
branch
6 times, most recently
from
0a0ce24 to
7ce8999
Compare
Thalley
changed the title
Implement the unicast to broadcast handover procedure, as per the Bluetooth CAP specificiation. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
github-actions
bot
added
area: Bluetooth
area: Bluetooth Audio
platform: nRF BSIM
github-actions
bot
requested review from
aescolar,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
sjanc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the unicast to broadcast handover procedure,
as per the Bluetooth CAP specificiation.